Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge and close file on end of stream event #38

Merged
merged 1 commit into from
May 18, 2023
Merged

Merge and close file on end of stream event #38

merged 1 commit into from
May 18, 2023

Conversation

gBillal
Copy link
Contributor

@gBillal gBillal commented May 18, 2023

Close #37

DominikWolek
DominikWolek approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@DominikWolek DominikWolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, exactly what I had in mind

@DominikWolek DominikWolek merged commit 9119a2d into membraneframework:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikWolek DominikWolek DominikWolek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sink should merge temporary file and close the main one on end of stream event
2 participants
@gBillal @DominikWolek